Skip to content

Refactor power policy to use direct async calls with power devices#553

Merged
RobertZ2011 merged 6 commits intoOpenDevicePartnership:v0.2.0from
RobertZ2011:power-policy-direct-async-call
Feb 11, 2026
Merged

Refactor power policy to use direct async calls with power devices#553
RobertZ2011 merged 6 commits intoOpenDevicePartnership:v0.2.0from
RobertZ2011:power-policy-direct-async-call

Conversation

@RobertZ2011
Copy link
Contributor

@RobertZ2011 RobertZ2011 commented Nov 3, 2025 •
edited
Loading

  • Instead of IPC between the power policy task and power devices, direct async function calls are used through the new DeviceTrait trait.
  • Power policy now holds references to types that impl DeviceTrait instead of using channels
  • There's now a per-device channel for sending events to the power policy instead of a single shared channel
  • Remove type-stated state machines, these just ended up in a shared enum so there wasn't much benefit while resulting in duplication of common logic.
  • Introduce first power policy integration test for default consumer switching logic
  • Update examples
  • Introduce temporary bridge code until type-C code is similarly refactored (types in type_c_service::wrapper::proxy).

@RobertZ2011 RobertZ2011 self-assigned this Nov 3, 2025
@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from 1588510 to aa3e2e0 Compare November 4, 2025 23:15
@github-actions
Copy link

github-actions bot commented Nov 4, 2025 •
edited
Loading

Cargo Vet Audit Passed

cargo vet has passed in this PR. No new unvetted dependencies were found.

@github-actions github-actions bot added the cargo vet PRs pending auditor review label Nov 4, 2025
@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from cda7d9a to 3467d89 Compare January 13, 2026 18:07
Copilot AI review requested due to automatic review settings January 13, 2026 18:07
@RobertZ2011 RobertZ2011 changed the base branch from main to v0.2.0 January 13, 2026 18:07
Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the power policy service architecture to use direct async calls instead of deferred IPC patterns. It introduces a proxy pattern for power device communication, extracts service message types into dedicated crates for better modularity, and adds comprehensive test coverage for the power policy service.

Changes:

  • Refactors power policy to use direct async communication with devices via a proxy pattern
  • Extracts thermal, debug, and battery service message types into separate reusable crates
  • Implements MCTP relay infrastructure in embedded-services for message routing
  • Adds test coverage for power policy consumer flows

Reviewed changes

Copilot reviewed 26 out of 32 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
type-c-service/src/wrapper/proxy.rs New proxy pattern for power device communication channels
power-policy-service/src/*.rs Refactored to use direct device trait calls instead of action state machine
thermal-service-messages/ New crate containing thermal service request/response types
debug-service-messages/ New crate containing debug service request/response types
battery-service-messages/ New crate containing battery service request/response types
embedded-service/src/relay/ New MCTP relay infrastructure for message serialization
embedded-service/src/event.rs New event sender/receiver traits
embedded-service/src/power/policy/device.rs Refactored device with InternalState and DeviceTrait
espi-service/src/mctp.rs MCTP relay implementation using new infrastructure
power-policy-service/tests/ New test files for consumer flows
examples/std/src/bin/*.rs Updated examples for new architecture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 22, 2026 19:47
@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from 4be5bff to a838d81 Compare January 22, 2026 19:47
Copilot AI reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 38 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 22, 2026 21:54
@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from d3aa53a to 57c10a6 Compare January 22, 2026 21:54
Copilot AI reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 40 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from 57c10a6 to fbe2f13 Compare January 22, 2026 22:42
Copilot AI review requested due to automatic review settings January 22, 2026 22:45
@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from fbe2f13 to fd95083 Compare January 22, 2026 22:45
Copilot AI reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 40 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 29, 2026 00:07
@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from 31b3b00 to 69a1d6b Compare January 29, 2026 00:07
Copilot AI reviewed Jan 29, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 45 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 29, 2026 19:46
@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from bbc2ee1 to d29f8b6 Compare January 29, 2026 19:51
Copilot AI reviewed Jan 29, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 45 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RobertZ2011 RobertZ2011 dismissed stale reviews from kurtjd and tullom via da6465a February 9, 2026 18:06
@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from 97c2fe1 to da6465a Compare February 9, 2026 18:06
Copilot AI reviewed Feb 9, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 48 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from 1e56d48 to c364a43 Compare February 11, 2026 19:11
@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from c364a43 to ea9c6d9 Compare February 11, 2026 19:12
Copilot AI reviewed Feb 11, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 48 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RobertZ2011 RobertZ2011 force-pushed the power-policy-direct-async-call branch from ea9c6d9 to be39e10 Compare February 11, 2026 19:31
Copilot AI review requested due to automatic review settings February 11, 2026 19:42
Copilot AI reviewed Feb 11, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 47 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RobertZ2011 RobertZ2011 merged commit ef2ed88 into OpenDevicePartnership:v0.2.0 Feb 11, 2026
21 checks passed
@RobertZ2011 RobertZ2011 linked an issue Feb 12, 2026 that may be closed by this pull request
Refactor power policy to use direct async calls #598
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kurtjd kurtjd kurtjd approved these changes

@asasine asasine asasine approved these changes

@tullom tullom tullom approved these changes

@jerrysxie jerrysxie jerrysxie approved these changes

@gjpmsft gjpmsft Awaiting requested review from gjpmsft gjpmsft is a code owner automatically assigned from OpenDevicePartnership/ec-usb-c-pd-team

@seanbrns seanbrns Awaiting requested review from seanbrns seanbrns is a code owner automatically assigned from OpenDevicePartnership/ec-battery-team

@thdesil thdesil Awaiting requested review from thdesil thdesil is a code owner automatically assigned from OpenDevicePartnership/ec-battery-team

@williampMSFT williampMSFT Awaiting requested review from williampMSFT williampMSFT is a code owner automatically assigned from OpenDevicePartnership/ec-code-owners

@madeleyneVaca madeleyneVaca Awaiting requested review from madeleyneVaca madeleyneVaca is a code owner automatically assigned from OpenDevicePartnership/ec-code-owners

Assignees

@RobertZ2011 RobertZ2011

Labels

cargo vet PRs pending auditor review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor power policy to use direct async calls

5 participants

@RobertZ2011 @jerrysxie @kurtjd @asasine @tullom